Re: [PATCH v4 01/10] PWM: add pwm framework support
From: Thierry Reding <hidden>
Date: 2012-03-20 05:59:30
Also in:
linux-arm-kernel, linux-tegra
Possibly related (same subject, not in this thread)
- 2012-03-20 · Re: [PATCH v4 01/10] PWM: add pwm framework support · Stephen Warren <hidden>
- 2012-03-16 · Re: [PATCH v4 01/10] PWM: add pwm framework support · Thierry Reding <hidden>
- 2012-03-16 · Re: [PATCH v4 01/10] PWM: add pwm framework support · Shawn Guo <hidden>
- 2012-03-14 · Re: [PATCH v4 01/10] PWM: add pwm framework support · Thierry Reding <hidden>
- 2012-03-14 · Re: [PATCH v4 01/10] PWM: add pwm framework support · Lars-Peter Clausen <hidden>
* Stephen Warren wrote:
On 03/14/2012 09:56 AM, Thierry Reding wrote:quoted
From: Sascha Hauer <redacted> This patch adds framework support for PWM (pulse width modulation) devices....quoted
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c...quoted
+/** + * pwmchip_add() - register a new pwm + * @chip: the pwm + * + * register a new pwm. pwm->pwm_id must be initialized. if pwm_id < 0 then + * a dynamically assigned id will be used, otherwise the id specified, + */I don't see anywhere in the code that implements "if pwm_id < 0 then a dynamically assigned id will be used".
The second patch in the series fixes up this comment when the functionality is properly implemented. I still wanted to go over the first patch and fix up some minor things, so maybe I'll fix this up as I go along. Thierry