Re: [PATCH] Don't use non-standard echo options for fdtget-runtest.sh

On Sun, Mar 18, 2012 at 07:26:58PM -0700, Simon Glass wrote:

Hi John,

On Sun, Mar 18, 2012 at 6:56 PM, David Gibson
[off-list ref] wrote:

quoted

fdtget-runtest.sh currently uses the "-e" option to echo, for interpreting
string escapes.  But this option is only understood by some versions of
echo - the one in bash does, but the one in dash does not.  In fact since
I reworked the fdtget tests a while back, we no longer need the escape
expanding feature of echo here, so this patch simple removes the -e to
fix the problem (the testsuite now passes when /bin/sh is dash).

Signed-off-by: David Gibson <redacted>

This was put in for this test:

    # Test multiple arguments
    run_fdtget_test "MyBoardName\nmemory" -ts $dtb / model /memory device_type

Without the -e the test fails for me... Do I need a later patch that
has not been applied? I tried with de6b762.

Ah.  Looks like dash interprets the \n in the quoted string, rather
than in echo.  So with my patch it works with dash, but not bash.

Ignore that patch, I'll look for a way to work with both.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson