Re: [PATCH] stmmac: Add device-tree support

On 16:30 Mon 12 Mar     , Giuseppe CAVALLARO wrote:

On 3/12/2012 4:06 PM, Stefan Roese wrote:

quoted

Hi Rob,

On Monday 12 March 2012 15:34:59 Rob Herring wrote:

quoted

On 03/12/2012 09:05 AM, Stefan Roese wrote:

quoted

This patch adds support to configure the STMMAC ethernet driver via
device-tree instead of platform_data.

Currently, only the properties needed on SPEAr600 are provided. All
other properties should be added once needed on other platforms.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Giuseppe Cavallaro <redacted>
Cc: Viresh Kumar <redacted>
---

 Documentation/devicetree/bindings/net/stmmac.txt   |   38 +++++++++++
 .../net/ethernet/stmicro/stmmac/stmmac_platform.c  |   66
 +++++++++++++++++++- 2 files changed, 103 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/net/stmmac.txt

diff --git a/Documentation/devicetree/bindings/net/stmmac.txt

b/Documentation/devicetree/bindings/net/stmmac.txt new file mode 100644
index 0000000..386a47f

--- /dev/null
+++ b/Documentation/devicetree/bindings/net/stmmac.txt

@@ -0,0 +1,38 @@
+* STMicroelectronics 10/100/1000 Ethernet driver (GMAC)
+
+Required properties:
+- compatible: Should be "stm,gmac"

This is too generic. This should be 1 string per version of h/w.

Viresh, Giuseppe, can you please suggest a proper string for the SPEAr600 
STMMAC core, including version?
 

quoted

'stm' should be 'st' according to vendor-prefixes.txt.

I'm not familiar with devicetree; maybe we should have:

"stmicro,mac100"
"stmicro,gmac"

or: st instead of stmicro if you prefer.

you need to put the first soc where the ip appear on gmac it's sti7105

but with PM IIRC it's sti7108

Best Regards,
J.