Thread (3 messages) 3 messages, 2 authors, 2012-03-09

Re: [PULL] of nand generic binding

From: Jean-Christophe PLAGNIOL-VILLARD <hidden>
Date: 2012-03-09 10:09:32
Also in: linux-arm-kernel

Possibly related (same subject, not in this thread)

On 18:44 Thu 08 Mar     , Grant Likely wrote:
On Wed, 07 Mar 2012 07:43:30 -0600, Rob Herring [off-list ref] wrote:
quoted
On 03/07/2012 02:29 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
quoted
On 16:25 Wed 29 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
quoted
On 16:57 Fri 17 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
quoted
HI,

	please find attached the generic binding for the MTD nand

	This will add boolean and nand helpers
is it ok?
I need this for 3.4

will you apply it or can I apply it via AT91
Looks fine to me and Grant acked it, so go ahead and take with your at91
branch.
Actually, taking another look at the of_mtd patch, that stuff really
belongs in the drivers/mtd directory.  I'm not nacking the patch, but
you should send a follow up to move it into the correct place.
today of generic binding are all in drivers/of

I don't like the of_property_read_bool patch.  I don't want the
of_property_read_ functions to mix data return and error codes.
Either return a bool with an error code in the parameter list, or the
other way around.  Otherwise we'll end up with the same problem as
APIs that use the ERR_PTR() pattern where callers will use it without
understanding that the return value isn't necessarily a bool.
I update as I reply

and can I've a go I've all the binding for at91 reallying on it

Best Regards,
J.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help