Re: [PATCH 2/5 v3] ARM: at91: sam9g20 add i2c DT support

On 22:26 Thu 08 Mar     , Grant Likely wrote:

On Thu,  8 Mar 2012 09:50:32 +0100, Jean-Christophe PLAGNIOL-VILLARD [off-list ref] wrote:

quoted

For now on use i2c-gpio driver on the same pin as the hardware IP.

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
Cc: Nicolas Ferre <redacted>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
---
v3:

	update i2c binding (Rob comments)

Best Regards,
J.
 arch/arm/boot/dts/at91sam9g20.dtsi |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/at91sam9g20.dtsi b/arch/arm/boot/dts/at91sam9g20.dtsi
index 4b0dc99..072b2da 100644
--- a/arch/arm/boot/dts/at91sam9g20.dtsi
+++ b/arch/arm/boot/dts/at91sam9g20.dtsi

@@ -189,4 +189,17 @@
 			status = "disabled";
 		};
 	};
+
+	i2c-gpio@0 {

i2c@0

quoted

+		compatible = "i2c-gpio";
+		gpios = <&pioA 23 0 /* sda */
+			 &pioA 24 0 /* scl */
+			>;
+		i2c-gpio,sda-open-drain;
+		i2c-gpio,scl-open-drain;
+		i2c-gpio,delay-us = <2>;	/* ~100 kHz */
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "disabled";
+	};

gpio-driven i2c busses are inherently board-specific.  Why is this
in the SoC include file?

because they use the hw pin and all board will use the same as on some soc
(old) we can not use the hw IP

Otherwise I think this patch series looks okay.

Best Regards,
J.