Re: [PATCH 09/11] ARM: tegra: Rewrite PCIe support as a driver
From: Stephen Warren <hidden>
Date: 2012-03-08 20:09:04
Also in:
linux-arm-kernel, linux-pci, linux-tegra
On 03/08/2012 07:51 AM, Thierry Reding wrote:
Signed-off-by: Thierry Reding <redacted>
Patch description?
quoted hunk
diff --git a/arch/arm/mach-tegra/board-harmony-pcie.c b/arch/arm/mach-tegra/board-harmony-pcie.c
...
-static int __init harmony_pcie_init(void) +static int tegra_pcie_init(struct platform_device *pdev)
That name should probably still be called harmony_something() since it's still board-specific. I wonder how having a per-board callback will integrate with device tree. I guess I'll find out when I review patch 11:-)
quoted hunk
diff --git a/arch/arm/mach-tegra/board-trimslice.c b/arch/arm/mach-tegra/board-trimslice.c
+static int __init trimslice_pci_init(void)
{
if (!machine_is_trimslice())
return 0;You can remove that test now.
quoted hunk
diff --git a/arch/arm/mach-tegra/board.h b/arch/arm/mach-tegra/board.h
+#define TEGRA_PCIE_MAX_PORTS 2
+
+struct tegra_pcie_pdata {
+ int (*init)(struct platform_device *pdev);
+ int (*exit)(struct platform_device *pdev);
+ bool enable_ports[TEGRA_PCIE_MAX_PORTS];
+};That's a somewhat odd place to put the header; a dedicated mach-tegra/include/mach/tegra_pcie_pdata.h or include/linux/platform_data/tegra_pcie.h might make more sense. Aside from those pretty minor issues, this all looks great. Thanks for fixing our driver!