Thread (3 messages) flat view 3 messages, 3 authors, 2012-03-08

Re: [PATCH 06/11] PCI: Keep pci_fixup_irqs() around after init

From: Thierry Reding <hidden>
Date: 2012-03-08 18:37:31
Also in: linux-arm-kernel, linux-pci, linux-tegra

* Bjorn Helgaas wrote:
Hmm, your patch looks OK as far as it goes, but the implementation of
pci_fixup_irqs() as a call-once-at-boot-time thing with a loop through
all the PCI devices we've found so far looks completely broken with
regard to hotplug.

Who does the swizzle for devices hot-added after boot?
Perhaps I should have mentioned this in the commit message, but the patch
isn't actually used in a hotplug scenario. In fact, the code is still run
once at boot time, only very late. Grant's deferred probing allows the
PCIe controller driver to postpone initialization until all the devices
that it depends on (regulators) have been probed. This has the side-effect
that the probing actually takes place *after* code and data annotated with
__init have already been freed.

Thierry

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help