Re: [PATCH v5 4/9] tegra: fdt: i2c: Add extra I2C bindings for U-Boot

Hi Stephen,

On Wed, Mar 7, 2012 at 12:39 PM, Stephen Warren [off-list ref] wrote:

On 03/06/2012 10:00 PM, Simon Glass wrote:

quoted

Add U-Boot's peripheral clock information to the Tegra20 device tree file.

Signed-off-by: Simon Glass <redacted>

...

quoted

diff --git a/doc/device-tree-bindings/i2c/tegra20-i2c.txt b/doc/device-tree-bindings/i2c/tegra20-i2c.txt

...

quoted

+Required properties:
+ - clocks : Two clocks must be given, each as a phandle to the Tegra's
+            CAR node and the clock number as a parameter:

I'd rather rely on the common clock binding documentation for the format
of the clock specifiers than duplicate the information here. True, that
document isn't in U-Boot (nor is it final). I.e.:

   Two clocks must be specified:

But I think this is fine for now (I might care more if submitting a doc
file for the kernel tree), so

Acked-by: Stephen Warren <redacted>

Thanks. Good to get this in.

Regards,
Simon

quoted

+     - the I2C clock to use for the peripheral
+     - the pll_p_out3 clock, which can be used for fast operation. This
+          does not change and is the same for all I2C nodes.
+
+Example:
+(TODO: merge with existing example):
+
+     i2c@7000c400 {
+             #address-cells = <1>;
+             #size-cells = <0>;
+             compatible = "nvidia,tegra20-i2c";
+             reg = <0x7000C400 0x100>;
+             interrupts = < 116 >;
+             /* PERIPH_ID_I2C2, PLL_P_OUT3 */
+             clocks = <&tegra_car 54>, <&tegra_car 124>;
+     };