Re: [PATCH] of/irq: add empty irq_of_parse_and_map() for non-dt builds
From: Thomas Abraham <hidden>
Date: 2012-03-25 14:56:18
Also in:
lkml
On 25 March 2012 06:12, Grant Likely [off-list ref] wrote:
On Sat, 24 Mar 2012 08:12:39 -0500, Rob Herring [off-list ref] wrote:quoted
On 03/24/2012 04:27 AM, Thomas Abraham wrote:quoted
Add a empty irq_of_parse_and_map() that returns 0 for non-dt builds and avoid having #ifdef CONFIG_OF around all calls to irq_of_parse_and_map(). Suggested-by: Grant Likely <redacted> Signed-off-by: Thomas Abraham <redacted> ---Acked-by: Rob Herring <redacted> Go ahead and merge with the rest of your series.Actually, it's not quite fully baked; the forward declaration of irq_of_parse_and_map() needs to be moved under the #if defined(CONFIG_OF_IRQ) block (just move the #if statement up 7 lines). After doing that you can add my acked-by and merge it with the rest of your series. There is no sense merging it through my tree when you are the only user depending on it. Acked-by: Grant Likely <redacted>
Thanks. I will do that change which you have suggested and take it through the Samsung tree. But I was thinking that if it goes through your tree, there would be less chances of a merge conflict in include/linux/of_irq.h, a file that might see updates from other sources. Thanks, Thomas.