Re: [PATCH v1 1/5] ARM: imx28: add basic dt support
From: Lothar Waßmann <hidden>
Date: 2012-03-15 06:54:06
Also in:
linux-arm-kernel, linux-mmc, lkml
Hi, Dong Aisheng writes:
On Wed, Mar 14, 2012 at 10:16:43PM +0800, s.hauer@pengutronix.de wrote:quoted
On Wed, Mar 14, 2012 at 08:45:23PM +0800, Dong Aisheng wrote:quoted
On Wed, Mar 14, 2012 at 01:23:51AM +0800, Grant Likely wrote:
[...]
quoted
quoted
But it seems this needs pass mac address to fec driver via platforom data which is not friendly to dt. Another way may be changing fec driver to get the fixed part of mac address(first two bytes) from device tree and read the left dynamical part from otp which i'm not sure is better enough. BTW, filling with zeros seems not work since it's invalid mac address.Yes, that's the idea of using this value...But comparing to use an invalid value, why not just do not define that local-mac-address property?
Because a MAC address is by definition a GLOBALLY UNIQUE IDENTIFIER which is contrary to coding a "valid" default value for it somewhere! The owner of a certain MAC address range (OUI) is responsible for ensuring the uniqueness. Thus only they may assign a specific MAC address to a specific device. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________