Re: [PATCH v4 4/9] tegra: fdt: i2c: Add extra I2C bindings for U-Boot

On 02/29/2012 01:32 PM, Simon Glass wrote:

Hi Stephen,

On Wed, Feb 29, 2012 at 12:21 PM, Stephen Warren [off-list ref] wrote:

quoted

On 02/29/2012 10:31 AM, Simon Glass wrote:

quoted

Add U-Boot's peripheral clock information to the Tegra20 device tree file.

quoted

diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi

quoted

              compatible = "nvidia,tegra20-i2c";
              reg = <0x7000C000 0x100>;
              interrupts = < 70 >;
+             clocks = <&tegra_car 12>;       /* PERIPH_ID_I2C1 */
      };

The I2C modules all require 2 clocks; the one you've added in this patch
and a second reference to pll_p_out3. Can you please list both of these
here, and update the I2C binding to describe the set of clocks that it
requires. Thanks.

OK - do you have a pointer to the kernel commit please? I always seem
to have trouble tracking this stuff down.

The clock stuff isn't in the kernel yet, so there's no commit to point
to. The commit I asked you to create would update the bindings to define
which clocks the I2C node needs, and would then go into U-Boot and the
kernel.

As a reference though, look at the kernel I2C driver and see that it
performs two clk_get() calls, and then look into tegra2_clocks.c to see
the two clocks it matches.

-- 
nvpublic