RE: [PATCH v3 07/10] arm/tegra: Add PWFM controller device tree probing
From: Stephen Warren <hidden>
Date: 2012-02-28 21:20:25
Also in:
linux-arm-kernel, linux-tegra
Possibly related (same subject, not in this thread)
- 2012-03-05 · RE: [PATCH v3 07/10] arm/tegra: Add PWFM controller device tree probing · Stephen Warren <hidden>
- 2012-03-05 · Re: [PATCH v3 07/10] arm/tegra: Add PWFM controller device tree probing · Thierry Reding <hidden>
- 2012-03-05 · RE: [PATCH v3 07/10] arm/tegra: Add PWFM controller device tree probing · Stephen Warren <hidden>
- 2012-03-04 · Re: [PATCH v3 07/10] arm/tegra: Add PWFM controller device tree probing · Arnd Bergmann <hidden>
- 2012-03-03 · Re: [PATCH v3 07/10] arm/tegra: Add PWFM controller device tree probing · Thierry Reding <hidden>
Thierry Reding wrote at Wednesday, February 22, 2012 8:17 AM:
Add auxdata to instantiate a device tree for the PWFM controller and include a corresponding node in the device tree.
quoted hunk
diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
+ pwm: pwm@7000a000 {
+ compatible = "nvidia,tegra20-pwm";
+ reg = <0x7000a000 0x100>;
+ #pwm-cells = <2>;
+ };
The compatible value probably should list both Tegra30 and Tegra20, so
we can know exactly which HW is present, just in case we need to turn
on some bug-fix only for one of the variants:
compatible = "nvidia,tegra30-pwm", "nvidia,tegra20-pwm";
Could you also write binding documentation, in particular explaining
what the two pwm-cells are specifically for Tegra:
Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt
(although perhaps that'd be part of the previous patch which implements
the driver)
--
nvpublic