Re: [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard
From: Simon Glass <sjg@chromium.org>
Date: 2012-02-28 18:46:13
Also in:
linux-tegra, u-boot
Hi Stephen, On Tue, Feb 28, 2012 at 10:41 AM, Stephen Warren [off-list ref] wrote:
Simon Glass wrote at Tuesday, February 28, 2012 11:37 AM:quoted
On Tue, Feb 28, 2012 at 10:31 AM, Stephen Warren [off-list ref] wrote:quoted
Simon Glass wrote at Tuesday, February 28, 2012 10:38 AM: ...quoted
I am going to add your binding, less the #clock-cells which U-Boot currently can't support because it conflicts with the C preprocessor (at some point I may look at a patch to use sed or some other means of avoiding this).Out of curiosity, why does the C preprocessor come into it? Is U-Boot's build process running cpp on the .dts files or something? That's non- standard, although perhaps it could be a useful standard...Yes, but at the moment we only use it for '/include/ ARCH_CPU_DTS'.Uggh. That's going to make the device tree files look different between the kernel and U-Boot:-( With # disallowed in particular, it's going to prevent U-Boot from /ever/ using the correct protocols for parsing the device tree. This seems like an extremely bad idea.
Until we change it in U-Boot, you mean. We could move to sed or pre- and post-process the file to remove and re-insert the #.
quoted
Still hoping your symbolic stuff will go in though.That looks extremely unlikely in its current form. Ideally, I will get time to take Jon's or David's patches and push one of them forward to provide a more complete solution, but it's a very long way out either way.
That's a shame. Regards, Simon
-- nvpublic