Re: [PATCH V2 1/4] i2c: tegra: Add __devinit/exit to probe/removeG

On Fri, Jan 06, 2012 at 08:47:11AM -0800, Stephen Warren wrote:

Ben Dooks wrote at Friday, January 06, 2012 9:26 AM:

quoted

On Tue, Dec 20, 2011 at 01:47:29PM -0800, Stephen Warren wrote:

quoted

Shubhrajyoti Datta wrote at Monday, December 19, 2011 11:15 PM:
...

quoted

Hi Stephen ,
could you check this one also
thanks.

From: Shubhrajyoti D <redacted>
Date: Tue, 20 Dec 2011 11:40:51 +0530
Subject: [PATCH] I2C : tegra : devexit in remove

Adding I2C __devexxit in remove

Cc: Stephen Warren <redacted>
Signed-off-by: Shubhrajyoti D <redacted>

Acked-by: Stephen Warren <redacted>

Ben or Olof,

quoted

-       .remove  = tegra_i2c_remove,
+       .remove  =__devexit_p(tegra_i2c_remove),

When you apply this, can you fix it up to add a space after the = in
the modified line? If you want, I can post an updated version to do that.

Let me know if you want anything applying or a pull-request processed.

I think once fixed the patches would be fine and I ack them:

Acked-by: Ben Dooks <redacted>

Olof, since you took the original through the Tegra tree, I think it
makes sense for us to take this fix through there too, and for 3.3?
The patch above is http://patchwork.ozlabs.org/patch/132349/

Done, applied, sorry for the delay.

The patch has whitespace damage but I fixed it up manually.


-Olof