Thread (1 message) 1 message, 1 author, 2012-02-01

Re: [PATCH] spi/spi-altera: Allow to explicitely override bus number via dts

From: Frederic LAMBERT <hidden>
Date: 2012-02-01 15:52:14
Also in: linux-spi

2012/2/1 Mark Brown [off-list ref]
Well, something that walks all block devices on Linux is very
straightforward...  It sounds like you just want logic along the lines
of "find a block device and offer the option of overriding by providing
a specific path for use with a file", is that about right?
Well, yes, excepted that the file *is* equivalent to a block device for my
piece of code!

 > Although I tend to agree you on the fact that SPI bus num is a SPI core
quoted
matter, but the fact is that, for now, it is the controller that must
fill
quoted
the spi_master structure to call spi_master_get(), and that this
structure
quoted
contains a field 'bus_num' that is always initialized to -1 since DTS...
This sounds like a simple matter of proramming to change.  Clearly
providing a standard feature of the SPI subsystem will involve
modification of the SPI core, for example to change the interpretation
of -1 to go look at the device tree and override it.
Yes, that seems simple said like that.
It was thus more simple for me, at that time, to modify a specific driver
for a specific port (Nios2), than to modify a core used by every one.
Question of time, and confidence in my own capacities :-).
The other point being the change acceptation (and the time it takes) by the
community...

-- 
Fred
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help