Re: [PATCH v6 9/9] ARM: vexpress: Add Device Tree for V2P-CA15 core tile (TC1 variant)
From: Pawel Moll <hidden>
Date: 2012-01-19 17:27:15
Also in:
linux-arm-kernel
Possibly related (same subject, not in this thread)
- 2012-01-31 · Re: [PATCH v6 9/9] ARM: vexpress: Add Device Tree for V2P-CA15 core tile (TC1 variant) · Dave Martin <hidden>
- 2012-01-30 · Re: [PATCH v6 9/9] ARM: vexpress: Add Device Tree for V2P-CA15 core tile (TC1 variant) · Grant Likely <hidden>
- 2012-01-30 · Re: [PATCH v6 9/9] ARM: vexpress: Add Device Tree for V2P-CA15 core tile (TC1 variant) · Dave Martin <hidden>
- 2012-01-19 · Re: [PATCH v6 9/9] ARM: vexpress: Add Device Tree for V2P-CA15 core tile (TC1 variant) · Grant Likely <hidden>
- 2012-01-19 · Re: [PATCH v6 9/9] ARM: vexpress: Add Device Tree for V2P-CA15 core tile (TC1 variant) · Nicolas Pitre <nico@fluxnic.net>
On Thu, 2012-01-19 at 17:00 +0000, David Vrabel wrote:
The problem wasn't with including skeleton.dtsi.
Including as it is creates two device_type="memory" nodes, one with regs=<0 0>, which is definitely wrong.
With CONFIG_ARM_ATAG_DTB_COMPAT the zImage decompressor modifies the appended DTB using information from the ATAGs (see atags_to_fdt()). If there's an ATAG giving the amount of RAM the DTB's "memory" node is replaced with a new one. Since the vexpress DTBs don't have a "memory" node it's added and the DTB ends up with two nodes describing memory.
The "memory@address" node name is in my opinion perfectly legal - p. 3.4 of the DT spec says "The name component of the node name (see 2.2.1) shall be memory.". So the decompressor code may be wrong in looking for adress-less "memory" node... One way or the other, I'll get this fixed. Thanks for letting me know! Paweł _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel