Hello,

I added the "devicetree-discuss" ml.

On 01/12/2012 04:34 PM, Richard Retanubun wrote:

Hello,

I am wondering if it is okay to add .compatible entries for mpc8360 and
declare its data structure
to mpc-i2c.c

something like this:

{.compatible = "fsl,mpc8360-i2c", .data = &mpc_i2c_data_8360, },

static struct mpc_i2c_data mpc_i2c_data_8360 __devinitdata = {
    .setup = mpc_i2c_setup_8xxx,
};

or is the intended approach to match the closest thing to your CPU (in
this case mpc8313) ?

Yes, it is intended to use the name of the compatible device, see:

http://lxr.linux.no/#linux+v3.2.1/arch/powerpc/boot/dts/kmeter1.dts#L69

Wolfgang