Re: [PATCH v4] serial/efm32: add new driver
From: Joe Perches <joe@perches.com>
Date: 2012-01-25 08:26:17
Also in:
linux-serial, lkml
On Wed, 2012-01-25 at 09:05 +0100, Uwe Kleine-König wrote:
Signed-off-by: Uwe Kleine-König <redacted>
trivial comments below:
quoted hunk ↗ jump to hunk
diff --git a/drivers/tty/serial/efm32-uart.c b/drivers/tty/serial/efm32-uart.c
[]
quoted hunk ↗ jump to hunk
@@ -0,0 +1,830 @@ +#if defined(CONFIG_SERIAL_EFM32_UART_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ) +#define SUPPORT_SYSRQ +#endif
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+static void efm32_uart_rx_chars(struct efm32_uart_port *efm_port,
+ struct tty_struct *tty)
+{[]
+ if ((rxdata & UARTn_RXDATAX_FERR) &&
+ !(rxdata & UARTn_RXDATAX_RXDATA__MASK)) {
Perhaps better as:
if ((rxdata & UARTn_RXDATAX_FERR) &&
!(rxdata & UARTn_RXDATAX_RXDATA__MASK)) {
and RXDATA__MASK with 2 underscores? perhaps just one _?
+static int efm32_uart_console_setup(struct console *co, char *options)
[]
+ for (i = 0; i < ARRAY_SIZE(efm32_uart_ports); ++i) {
+ if (efm32_uart_ports[i]) {
+ pr_warn("efm32-console: fall back to console index %u (from %hhi)\n",
+ i, co->index);
pr_warn("fall back to ..."
[]+ efm_port = efm32_uart_ports[co->index];
+ if (!efm_port) {
+ pr_warn("efm32-console: No port at %d\n", co->index);
pr_warn("No port at..."
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html