Re: [PATCH v3 4/4] ARM: omap: pass minimal SoC/board data for UART from dt
From: Tony Lindgren <tony@atomide.com>
Date: 2011-12-14 19:25:10
Also in:
linux-arm-kernel, linux-omap, linux-serial
* Rajendra Nayak [off-list ref] [111214 03:24]:
Pass minimal data needed for console boot, from dt, for OMAP4 panda/sdp and OMAP3 beagle boards, and get rid of the static initialization from generic board file. Acked-by: Rob Herring <redacted> Signed-off-by: Rajendra Nayak <redacted>
This we can't merge because this breaks serial console for omap2 because you're not adding the omap2 specific dtsi entries for omap2..
quoted hunk ↗ jump to hunk
--- a/arch/arm/mach-omap2/board-generic.c +++ b/arch/arm/mach-omap2/board-generic.c@@ -69,7 +69,6 @@ static void __init omap_generic_init(void) if (node) irq_domain_add_simple(node, 0); - omap_serial_init(); omap_sdrc_init(NULL, NULL); of_platform_populate(NULL, omap_dt_match_table, NULL, NULL);
..and you're removing the call for omap_serial_init. Please just update this patch with the omap2 entries as well. Other than that looks good to me. Tony