Re: [PATCH v3 2/6] ASoC: WM8903: Create default platform data structure
From: Mark Brown <hidden>
Date: 2011-12-02 00:29:40
Also in:
alsa-devel, linux-tegra
On Thu, Dec 01, 2011 at 01:49:20PM -0700, Stephen Warren wrote:
+ /* Default platform data, for use if none is supplied */ + defpdata.irq_active_low = false; + defpdata.micdet_cfg = 0; + defpdata.micdet_delay = 0;
No need to set things to zero (or just memset the structure).
+ defpdata.gpio_base = -1; + for (i = 0; i < ARRAY_SIZE(defpdata.gpio_cfg); i++) + defpdata.gpio_cfg[i] = 0xffffffff;
These should come after we've taken the copy, checking to see if there'a anything there before overwriting.