Thread (12 messages) 12 messages, 2 authors, 2011-11-30

Re: [PATCH v3 3/5] ARM: vexpress: Add DT support in v2m

From: Arnd Bergmann <arnd@arndb.de>
Date: 2011-11-30 13:34:40
Also in: linux-arm-kernel

On Wednesday 30 November 2011, Pawel Moll wrote:
On Tue, 2011-11-29 at 21:19 +0000, Arnd Bergmann wrote:
quoted
On Tuesday 29 November 2011, Pawel Moll wrote:
quoted
+                       compact-flash@1a000 {
+                               compatible = "ata-generic";
+                               reg = <0x1a000 0x100
+                                      0x1a100 0xf00>;
+                               reg-shift = <2>;
+                       };
Shouldn't there also be a more specific "compatible" value, in case we have
to detect this CF slot for some reason?
It was the compatible-value-of-choice in
"drivers/ata/pata_of_platform.c", unfortunately undocumented - as I have
just realized - in the "Documentation/devicetree/bindings"...
You should certainly *also* have "ata-generic" in there as the value
that is used by the existing driver, but it usually makes sense to have
a more specific value in addition, just as a precaution for the future,
in case that the specific hardware is not entirely identical to all others
and we have to do a separate workaround.
quoted
Is there actually no interrupt?
No, polling mode only. And yes, it works ;-)
Fascinating

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help