Re: [PATCH] net: add calxeda xgmac ethernet driver

Grant,

On 11/04/2011 11:57 AM, Grant Likely wrote:

On Wed, Oct 26, 2011 at 10:56 PM, Rob Herring [off-list ref] wrote:

quoted

From: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>

Add support for the XGMAC 10Gb ethernet device in the Calxeda Highbank
SOC.

Signed-off-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>

Sinker question: is this a driver for an entirely new GMAC device
(designed from scratch) or is it based on an existing IP block?

Of course I'd rather use a existing driver. It is a new IP block.

quoted

+/**
+ * xgmac_init - Entry point for the driver
+ * Description: This function is the entry point for the driver.
+ */
+static int __init xgmac_init(void)
+{
+       return platform_driver_register(&xgmac_driver);
+}
+module_init(xgmac_init);
+
+/**
+ * xgmac_cleanup_module - Cleanup routine for the driver
+ * Description: This function is the cleanup routine for the driver.
+ */
+static void __exit xgmac_exit(void)
+{
+       platform_driver_unregister(&xgmac_driver);
+}
+module_exit(xgmac_exit);

You can drop some boilerplate with module_platform_driver() now.

Okay.

Rob