On Fri, Nov 18, 2011 at 1:51 PM, Stephen Warren [off-list ref] wrote:

Olof Johansson wrote at Friday, November 18, 2011 2:43 PM:

quoted

quoted

@@ -667,7 +710,12 @@ void tegra_pinmux_config_pullupdown_table(const struct tegra_pingroup_config *co

 }

 static struct of_device_id tegra_pinmux_of_match[] __devinitdata = {
+#ifdef CONFIG_ARCH_TEGRA_2x_SOC
    { .compatible = "nvidia,tegra20-pinmux", tegra20_pinmux_init },
+#endif
+#ifdef CONFIG_ARCH_TEGRA_3x_SOC
+   { .compatible = "nvidia,tegra30-pinmux", tegra30_pinmux_init },
+#endif

Again, provide empty stubs instead of ifdeffing the table.

Isn't it better for the driver not to support that compatible flag, rather
than claiming support, but then not actually working correctly?

Ah, yes, of course. I misread it as one of the scan tables, not used
for probing. Nevermind.


-Olof