Thread (1 message) 1 message, 1 author, 2011-10-12

Re: [PATCH v4 3/4] gpio/tegra: Convert to a platform device

From: Grant Likely <hidden>
Date: 2011-10-12 23:08:57
Also in: linux-arm-kernel, linux-tegra

On Tue, Oct 11, 2011 at 4:16 PM, Stephen Warren [off-list ref] wrote:
v3: Make regs variable static. Remove empty init of tegra_gpio_banks.

v2: Retrieve IRQ and memory addresses from resources instead of hard-
coding them. Add back initialization of tegra_gpio_chip.of_node.

Signed-off-by: Stephen Warren <redacted>
Acked-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>

One comment below however.
quoted hunk
@@ -333,28 +335,55 @@ static struct irq_chip tegra_gpio_irq_chip = {
 */
 static struct lock_class_key gpio_lock_class;

-static int __init tegra_gpio_init(void)
+static int __init tegra_gpio_probe(struct platform_device *pdev)
__devinit because this is put in the .probe hook of the driver.

g.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help