Re: [PATCH 5/9] regulator: helper routine to extract fixed_voltage_config

On Tue, Sep 27, 2011 at 03:42:48PM +0530, Rajendra Nayak wrote:

The helper routine of_get_fixed_voltage_config() extracts
fixed_voltage_config structure contents from device tree.

Also add documenation for additional bindings for fixed
regulators that can be passed through dt.

Why not just add device tree support into the driver directly?

+Optional properties:
+- regulator-fixed-supply: Name of the regulator supply

This is going to be confusing with respect to the generic regulator
supply property.

+- regulator-fixed-enable-high: Polarity of enable GPIO, 1 = Active High, 0 = Active low

Word wrap for legibility please.