Re: [PATCH 0/3] Variable sized cell support

On Wed, Sep 21, 2011 at 7:26 PM, David Gibson
[off-list ref] wrote:

On Wed, Sep 21, 2011 at 01:42:08PM -0700, Anton Staaf wrote:

quoted

This patch set adds, tests, and documents support for variable sized cells in
cell arrays.  The new syntax is:

    property = /size/ [8|16|32|64] <0x00 .... 0x12>;

So cell arrays of 8, 16, 32, or 64-bits can now be created.  No padding is
done on the resulting cell array.  So if three 8-bit cells are specified the
resulting property will contain three bytes.

This patch set assumes that the character literals in cell lists patch has
already been applied to your tree as it uses them in it's test case and the
diff will not apply cleanly to TOT without the character literals patch because
both patch sets modify the same locations in the parser.  You do not need to
apply the character literal support in bytestrings patch however.

Nice.

Thanks.

Still wants a little polish, I think.  And some time to sit around
in case we have a better idea on the syntax, but a very good start.

Yup, makes sense.  I'll submit a v2 today that addresses your other comments.

-Anton

--
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                               | _way_ _around_!
http://www.ozlabs.org/~dgibson