Re: [PATCH v2 3/3] dtc: Support character literals in bytestrings

On Thu, Sep 08, 2011 at 12:07:16AM -0700, Grant Likely wrote:

On Thu, Sep 08, 2011 at 01:51:49PM +1000, David Gibson wrote:

quoted

On Wed, Sep 07, 2011 at 04:15:40PM -0700, Anton Staaf wrote:

quoted

With this patch the following property assignment:

    property = ['a' 2b '\r'];

is equivalent to:

    property = [61 2b 0d];

So, I still have some reservations about this syntax.

It occurred to me: do you actually need to intermix character and
hexbyte values that much?  Could I suggest an alternate sytax as:

	property = 'a', [2b], 'r';

The new character literals sufficiently distinct not to cause problems
here, and it maintains the , == bytestring append behaviour we already
have.

Thoughts?

Does it matter much?  I'm happy with either.  Is there a downside to
the first syntax?

Well.. probably not.  I'm just nervous about adding anything in the
lexically weird bytestring context.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson