Re: [PATCH] powerpc/85xx: clean up FPGA device tree nodes for Freecsale QorIQ boards
From: Kumar Gala <hidden>
Date: 2011-08-31 02:26:40
Also in:
linuxppc-dev
On Aug 29, 2011, at 2:09 PM, Timur Tabi wrote:
Standarize and document the FPGA nodes used on Freescale QorIQ reference boards. There are three kinds of FPGAs used on the boards: pixis, qixis, and cpld. Although their are minor differences among the boards that have one kind of FPGA, most of the functionality is the same, so it makes sense to create common compatibility strings. Signed-off-by: Timur Tabi <redacted> --- Changes for other Freescale boards will be made in future patches. .../devicetree/bindings/powerpc/fsl/board.txt | 30 ++++++++++++-------- arch/powerpc/boot/dts/p1010rdb.dts | 10 ++---- arch/powerpc/boot/dts/p1020rdb.dts | 7 ++++- arch/powerpc/boot/dts/p1022ds.dts | 2 +- arch/powerpc/boot/dts/p2020ds.dts | 5 +++ arch/powerpc/boot/dts/p2020rdb.dts | 4 ++ arch/powerpc/boot/dts/p2040rdb.dts | 8 ++++- arch/powerpc/boot/dts/p3041ds.dts | 4 +- arch/powerpc/boot/dts/p4080ds.dts | 8 ++++- arch/powerpc/boot/dts/p5020ds.dts | 4 +- 10 files changed, 55 insertions(+), 27 deletions(-)
Do we really want the generic "fsl,fpga-cpld" & "fsl,fpga-pixis"? This seems to vague. Also you need "pixis" on MPC8544DS, MPC8572DS, MPC8536DS. Also fpga-cpld makes no sense if we keep this. You are either a CPLD or FPGA not both. - k