Thread (4 messages) 4 messages, 3 authors, 2011-08-26

Re: [PATCH] tty: add a DesignWare 8250 driver

From: Jamie Iles <hidden>
Date: 2011-08-26 16:20:21
Also in: linux-serial
Subsystem: 8250/16?50 (and clone uarts) serial driver, the rest, tty layer and serial drivers · Maintainers: Greg Kroah-Hartman, Linus Torvalds, Jiri Slaby

On Fri, Aug 26, 2011 at 06:04:02PM +0200, Arnd Bergmann wrote:
On Friday 26 August 2011, Jamie Iles wrote:
quoted
The Synopsys DesignWare 8250 is an 8250 that has an extra interrupt that
gets raised when writing to the LCR when busy.  To handle this we need
special serial_out, serial_in and handle_irq methods.  Add a new
platform driver that uses these accessors.

Cc: Alan Cox <redacted>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jamie Iles <redacted>
The driver looks good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>

Is the patch to export serial8250_handle_irq already in Greg's tree or is that
still missing?
No, and I really don't know how I missed it.  I was sure an allmodconfig 
build worked, but perhaps 8250_dw wasn't selected.  Anyhow, here's the 
patch that does that.

Apologies again for making such a mess out of this series!

Thanks,

Jamie

8<---

From: Jamie Iles <redacted>
Subject: [PATCH] tty: 8250: export serial8250_handle_irq

Allow modules to use the normal 8250 irq handler inside their own.

Signed-off-by: Jamie Iles <redacted>
---
 drivers/tty/serial/8250.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/8250.c b/drivers/tty/serial/8250.c
index 6f594d2..435ce14 100644
--- a/drivers/tty/serial/8250.c
+++ b/drivers/tty/serial/8250.c
@@ -1588,6 +1588,7 @@ int serial8250_handle_irq(struct uart_port *port, unsigned int iir)
 
 	return 0;
 }
+EXPORT_SYMBOL_GPL(serial8250_handle_irq);
 
 static int serial8250_default_handle_irq(struct uart_port *port)
 {
-- 
1.7.4.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help