Thread (4 messages) 4 messages, 4 authors, 2011-08-22

Re: [PATCH 1/2] sound/soc/fsl/p1022_ds.c: add missing of_node_put

From: Timur Tabi <hidden>
Date: 2011-08-22 13:55:42
Also in: alsa-devel, kernel-janitors, lkml

Julia Lawall wrote:
From: Julia Lawall <redacted>

dma_channel_np has been accessed at this point, so decrease its reference
count before leaving the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier x;
expression E1!=0,E2,E3,E4;
statement S;
iterator I;
@@

(
if (...) { ... when != of_node_put(x)
               when != x = E3
               when != E3 = x
*  return ...;
 }
... when != x = E2
    when != I(...,x,...) S
if (...) { ... when != x = E4
 of_node_put(x); ... return ...; }
)
// </smpl>

Signed-off-by: Julia Lawall <redacted>
Acked-by: Timur Tabi <redacted>

Thanks, Julia.

-- 
Timur Tabi
Linux kernel developer at Freescale
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help