Thread (1 message) 1 message, 1 author, 2011-07-20

Re: Is there a binding for IORESOURCE_DMA population?

From: Shawn Guo <hidden>
Date: 2011-07-20 02:53:20

On Tue, Jul 19, 2011 at 05:16:56PM +0200, Arnd Bergmann wrote:
On Sunday 17 July 2011, Tabi Timur-B04825 wrote:
quoted
Shawn Guo wrote:
quoted
Ok, I will take this as a serious warning, and start evaluating the
driver consolidation.  I will absolutely need you help along the way.
At least, when we get there, I need your favor to test mpc platform,
as I do not have the access at all.
Absolutely.  I've been waiting a long time for someone to come along and 
help me unify the drivers.  As you know, there's very little collaboration 
between the ARM and PowerPC groups inside Freescale.
I've looked a bit at the two drivers, and it seems to me that both
would benefit from taking aspects from the other one.

Shawn, when you start the consolidation, I think it would be good
to first eliminate all the minor differences like variable names
and header file contents, always using the cleaner or more generic
version for each aspect. I've had some good success using 'vimdiff'
for similar work, which gives you a side-by-side representation of
the two files. There are evidently some more fundamental differences
like the DMA usage, but I think it's easier to leave them for
a later stage.

In some cases, you will have to abstract the differences between
the hardware like the mmio accessors that are not common between
powerpc and arm yet.

I also think that it would be useful to add the same device tree based
probing to the imx driver that is in the fsl one.
Arnd, thanks for all these points.

As the audio device tree support on i.mx still has a few other issues
to address besides this one, plus that I have got several board files
to convert to device tree, I guess it's going to be a while before I
can actually start it.

-- 
Regards,
Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help