On Mon, Jul 18, 2011 at 10:05:52AM -0700, Dmitry Torokhov wrote:

Hi Shawn,

On Monday, July 18, 2011 09:45:08 AM Shawn Guo wrote:

quoted

It adds device tree probe support for gpio-keys driver.

There is already a patch by David Jander adding device tree support to
the driver; I intend to apply it.

I just fetched it from linux-next.  Though it seems working for me,
I'm wondering why there are no bindings for following configurations.

struct gpio_keys_button {
	...
        int active_low;
	...
        bool can_disable;
        int value;              /* axis value for EV_ABS */
};

I'm seeing some platforms using them in their gpio_keys platform data.
Does that mean the dt version of the driver will be broken on these
platforms?

BTW, if I have fetched linux-next a little earlier or David Cc list
devicetree-discuss when he posted his patch, I do not have to waste
one day effort :)

-- 
Regards,
Shawn