Re: [PATCH v2] mtd: dataflash: add device tree probe support

On Thu, Jul 14, 2011 at 09:52:02PM +0400, Dmitry Eremin-Solenikov wrote:

On Thu, Jul 14, 2011 at 11:52:37PM +0800, Shawn Guo wrote:

quoted

It adds device tree probe support for mtd_dataflash driver.

Signed-off-by: Shawn Guo <redacted>
Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: David Woodhouse <redacted>
Cc: Artem Bityutskiy <redacted>
---
Changes since v1:
 * Add "atmel,at45xxx" into the match table
 * Add binding document

I´m sorry for being unclean on this. Device family is just at45,
so I´d suggest the following compatibility list:
"atmel,at45d789000", "atmel,at45"

Ok.

You might want to add "atmel,dataflash" or "mtd,dataflash", but I see
no point in that.

The binding I'm adding is for atmel dataflash (following the driver
name).  I want the binding to be scalable to cover possible new
atmel dataflash family other than at45.  We do not want to change
binding every time one new family comes out, do we?

-- 
Regards,
Shawn