Re: [PATCH v2 1/7] spi/imx: do not make copy of spi_imx_devtype_data
From: Lothar Waßmann <hidden>
Date: 2011-07-11 07:32:32
Also in:
linux-arm-kernel, linux-spi
Hi, Shawn Guo writes:
On Mon, Jul 11, 2011 at 09:15:34AM +0200, Lothar Waßmann wrote:quoted
Hi, Shawn Guo writes:quoted
spi_imx_devtype_data has already been driver private data. There is really no need to make a copy in spi_imx_data. Instead, a reference pointer works perfectly fine.You obviously overlooked, that the copy is done on purpose to keep only the data that is actually needed and discard everything else after initialisation.I did not overlook that, as I removed __devinitdata there.
But now you keep the whole array of which only one entry is being used instead of only the used entry. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________ ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general