Re: [PATCH v4 3/4] drivers/amba: create devices from device tree

On Fri, Jun 10, 2011 at 11:04:06PM +0200, Arnd Bergmann wrote:

On Friday 10 June 2011 22:48:42 Rob Herring wrote:

quoted

+#ifdef CONFIG_OF
+int of_amba_device_create(struct device_node *node, struct device *parent);

Actually, it would probably be good to have of_amba_device_create()
return a pointer to the created amba_device.

quoted

+#endif
+
+#else
+
+#ifdef CONFIG_OF
+static inline int of_amba_device_create(struct device_node *node, 
+                                       struct device *parent)
+{
+       return 0;
+}
+#endif
+

We normally don't use #ifdef around declarations like this, it doesn't
hurt to have them even when the code is not there. Otherwise the patch
looks good.

Yes, this hook will never get called or referenced by anything if
CONFIG_OF is not selected.  The only real user of it will be
drivers/of/platform.c

g.