Thread (1 message) 1 message, 1 author, 2011-06-08

Re: [RFC PATCH v3 2/2] dt: add custom device creation to platform bus scan

From: Arnd Bergmann <hidden>
Date: 2011-06-08 06:16:00
Also in: linux-arm-kernel

On Wednesday 08 June 2011 05:12:47 Rob Herring wrote:
quoted hunk
The simplest solutions are usually the best. With that, the 2nd patch 
becomes:

  static int of_dev_node_match(struct device *dev, void *data)
  {
@@ -234,6 +235,11 @@ static int of_platform_bus_create(struct 
device_node *bus,
                 return 0;
         }

+       if (of_device_is_compatible(bus, "arm,amba-device")) {
+               of_amba_device_create(bus, parent);
+               return 0;
+       }
+
Sounds good to me, just remind me what of_amba_device_create does when
amba is disabled. I guess it should do nothing in that case, there
can be no amba drivers loaded, so the device is clearly not needed.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help