Re: [PATCH 2/2] drivers/amba: probe via device tree

Arnd,

On 05/20/2011 09:21 AM, Arnd Bergmann wrote:

On Friday 20 May 2011 15:24:26 Rob Herring wrote:

quoted

Maybe we are looking this in the wrong way.

AMBA is not really the bus, but certain types of devices on the bus.
Granted, it may actually be an AMBA bus vs. vendor bus (i.MX AIPS), but
that is really transparent to s/w. Separating AMBA devices in the
devicetree is really Linux requirements defining the devicetree
structure. It is certainly conceivable that an OS could make no
distinction. In my case, there is a mixture of regular platform devices
and AMBA(Primecell really) devices all interleaved on the same bus.

I don't see how that would work. If the bus is AMBA, it should
only have AMBA devices on it, otherwise how would they be connected?

The ARM definition of AMBA encompasses a lot of things. It is the 
definition of the AXI, AHB and APB buses. It also has the definition of 
the peripheral ID register definitions which primarily only ARM Ltd 
peripherals implement. You can have those bus types yet not have any 
peripherals with the ID registers. The Linux amba bus primarily deals 
with just the peripheral ID for probe matching. There is also bus clock 
handling, but that's not really unique to an AMBA bus. Arguably the 
platform bus could have bus clock handling as well.

Whether software is supposed to know care about this is a different
question. The device tree should generally reflect the block
diagram of the hardware,

Agreed.

and I would expect the AMBA devices be
on a different level from the rest there.

But this part is not true.

quoted

Based on this, I think of_platform_populate should always just match
against "simple-bus" and make the matches parameter define the device
creation hook rather than the bus type. Or you could have both
bus_matches and dev_matches parameters.

I think it would be much better to only look at the parent bus for
device to add, never at the device itself.

If the bus is AMBA, add all devices as amba_device, if it's simple-bus,
add all devices as platform_device.

That is how it is currently, but the reality is that I only have 1 bus 
with both ARM Primecell peripherals and other peripherals which are 
standard platform bus devices. i2c-designware is one example. It is on 
the APB just like the pl011 uart. So do you propose I create a amba 
driver for it? It has no peripheral ID registers, so that may not even work.

Rob