Re: [PATCH 0/5] make sdhci device drivers self registered
From: Grant Likely <hidden>
Date: 2011-03-21 07:07:20
On Mon, Mar 21, 2011 at 12:58 AM, Grant Likely [off-list ref] wrote:
On Sun, Mar 20, 2011 at 9:42 PM, Shawn Guo [off-list ref] wrote:quoted
This patch set is to take sdhci device driver specific things out from sdhci-pltfm.c and make them self registered. Here are the difference it makes. * Get the sdhci device driver follow the Linux trend that driver take the registration by its own * sdhci-pltfm.c becomes significantly simpler and only has common support functions there * All sdhci device specific stuff are going back its own driver * The dt and non-dt support share the same pair of .probe and .remove hooks.Fantastic! Thanks for taking this on. I'll make a few comments, but this series really needs to be reposted to both the linux-kernel and linux-mmc lists.
On a brief glance, it looks pretty good. I need to take a deeper read into it tomorrow, but in general I like the way this series is looking. If you do the reposting right away, then I can make my comments on the linux-mmc list. Also, don't forget to cc: samuel when you repost. g.