Re: [PATCH v6] i2c-gpio: add devicetree support
From: Grant Likely <hidden>
Date: 2011-02-24 16:22:15
Also in:
linux-i2c, lkml
On Thu, Feb 24, 2011 at 12:00:13PM +0800, Thomas Chou wrote:
quoted hunk ↗ jump to hunk
From: Albert Herranz <redacted> This patch adds devicetree support to i2c-gpio driver. The allocation of local data is integrated to a private structure, and use devm_* helper for easy cleanup. It is base on an earlier patch for gc-linux from Albert Herranz [off-list ref]. Signed-off-by: Thomas Chou <redacted> CC: Albert Herranz <redacted> Acked-by: Haavard Skinnemoen <redacted> Acked-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> ---diff --git a/Documentation/devicetree/bindings/i2c/i2c-gpio.txt b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt new file mode 100644 index 0000000..38ef4f2 --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt@@ -0,0 +1,40 @@ +GPIO-based I2C + +Required properties: +- compatible : should be "i2c-gpio". +- gpios : should specify GPIOs used for SDA and SCL lines, in that order. +Optional properties: +- sda-is-open-drain : present if SDA gpio is open-drain. +- scl-is-open-drain : present if SCL gpio is open-drain. +- scl-is-output-only : present if the output driver for SCL cannot be + turned off. this will prevent clock stretching from working. +- speed-hz : SCL frequency.
Hi Thomas, One nitpick; I just looked, and other i2c controllers are already using 'clock-frequency' instead of 'speed-hz' for the speed of the bus. I'd like to see this patch use the same terminology. Otherwise this looks good to me. Thanks, g.