Re: [PATCH] of/pdt: allow DT device matching by fixing 'name' brokenness
From: Daniel Drake <hidden>
Date: 2011-02-23 20:06:50
Also in:
lkml, sparclinux
On 23 February 2011 19:54, Andres Salomon [off-list ref] wrote:
quoted
Wait; why are you binding to a device based on name? Binding by name and/or device_type is strongly discouraged for new code. Use compatible instead.Daniel posted a separate patch showing his code, would you mind commenting on that? I noticed he didn't cc you though, here's the patch: https://patchwork.kernel.org/patch/574901/
It does bind to the name. We don't currently have a compatible property for the battery device. We could fix that with a firmware upgrade, but it would break compatibility with all existing installs. I guess this is still the recommended approach... Daniel -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html