Re: [PATCH v9] spi: New driver for Altera SPI
From: Ryan Mallon <hidden>
Date: 2011-02-14 02:20:21
Also in:
linux-spi, lkml
On 02/14/2011 03:10 PM, Thomas Chou wrote:
This patch adds a new SPI driver to support the Altera SOPC Builder SPI component. It uses the bitbanging library. Signed-off-by: Thomas Chou <redacted> ---
+struct altera_spi {
+ /* bitbang has to be first */
+ struct spi_bitbang bitbang;Is this still true? I had a quick look and can't see anything which relies on spi_bitbang being the first entry. Things like this should be using container_of so that position in the struct is irrelevant. ~Ryan -- Bluewater Systems Ltd - ARM Technology Solution Centre Ryan Mallon 5 Amuri Park, 404 Barbadoes St ryan@bluewatersys.com PO Box 13 889, Christchurch 8013 http://www.bluewatersys.com New Zealand Phone: +64 3 3779127 Freecall: Australia 1800 148 751 Fax: +64 3 3779135 USA 1800 261 2934