Thread (10 messages) 10 messages, 4 authors, 2011-01-26

Re: [PATCH v4] smc91x: add devicetree support

flat view

From: Grant Likely <hidden>
Date: 2011-01-26 05:52:58
Also in: lkml, netdev

On Tue, Jan 25, 2011 at 10:22 PM, Thomas Chou [off-list ref] wrote:
Signed-off-by: Thomas Chou <redacted>
---
v2 specify part numbers in compat as Grant suggested.
v3 more specific part name.
v4 include match table only for OF as David suggested.

 drivers/net/smc91x.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)
Looks okay to me.

Reviewed-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
index 726df61..43654a3 100644
--- a/drivers/net/smc91x.c
+++ b/drivers/net/smc91x.c
@@ -81,6 +81,7 @@ static const char version[] =
 #include <linux/ethtool.h>
 #include <linux/mii.h>
 #include <linux/workqueue.h>
+#include <linux/of.h>

 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
@@ -2394,6 +2395,15 @@ static int smc_drv_resume(struct device *dev)
       return 0;
 }

+#ifdef CONFIG_OF
+static const struct of_device_id smc91x_match[] = {
+       { .compatible = "smsc,lan91c94", },
+       { .compatible = "smsc,lan91c111", },
+       {},
+}
+MODULE_DEVICE_TABLE(of, smc91x_match);
+#endif
+
 static struct dev_pm_ops smc_drv_pm_ops = {
       .suspend        = smc_drv_suspend,
       .resume         = smc_drv_resume,
@@ -2406,6 +2416,9 @@ static struct platform_driver smc_driver = {
               .name   = CARDNAME,
               .owner  = THIS_MODULE,
               .pm     = &smc_drv_pm_ops,
+#ifdef CONFIG_OF
+               .of_match_table = smc91x_match,
+#endif
       },
 };

--
1.7.3.5


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help