Re: [PATCH 2/3] sparc: make driver/of/pdt no longer sparc-specific

From: Andres Salomon <redacted>
Date: Mon, 9 Aug 2010 01:32:45 -0400

On Sun, 8 Aug 2010 23:12:21 -0600
Grant Likely [off-list ref] wrote:

quoted

If you have to explicitly cast these function pointers, then you're
doing it wrong.  :-)  Listen to and fix the compiler complaint here.

Hm, can you please expand on that?  The reason it's necessary to cast is
because sparc's prom_* functions are using ints instead of phandles.  I
don't understand why casting is the wrong thing here.

I could write some 1-line wrapper functions that simply call prom_*
rather than casting, I suppose.

There's no reason the Sparc interfaces can't take phandles since they
are just ints, and that would make the call signatures of these
functions compatible with the types used by the other architectures.