Thread (4 messages) 4 messages, 2 authors, 2010-07-25

Re: [PATCH] of: Provide default of_node_to_nid() when CONFIG_NUMA is not set

From: Stephen Rothwell <hidden>
Date: 2010-07-25 03:07:33
Also in: linuxppc-dev, lkml, sparclinux

Hi Grant,

On Sat, 24 Jul 2010 09:43:31 -0600 Grant Likely [off-list ref] wrote:
of_node_to_nid() is only relevant for NUMA.  Don't force architectures to
implement it if CONFIG_NUMA is not set.
Why not just do:

#ifndef of_node_to_nid
static inline int of_node_to_nid(struct device_node *device) { return 0; }
#define of_node_to_nid	of_node_to_nid
#endif

in include/linux/of.h

and then add:

#define of_node_to_nid	of_node_to_nid

Where it is declared/defined for each arch ...
(it would be nice if all the archs were consistent in where it was
declared).
-- 
Cheers,
Stephen Rothwell                    sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org
http://www.canb.auug.org.au/~sfr/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help