Re: [PATCH 2/2] powerpc/mpc5121: add initial support for PDM360NG board

Hi Grant,

On Sun, 2 May 2010 08:54:26 -0600
Grant Likely [off-list ref] wrote:

Hi Anatolij,

Comments below.

On Fri, Apr 30, 2010 at 2:30 PM, Anatolij Gustschin [off-list ref] wrote:

quoted

Adds IFM PDM360NG device tree, and platform code.

...

quoted

+       nfc@40000000 {
+               compatible = "fsl,mpc5121-nfc";
+               reg = <0x40000000 0x100000>;
+               interrupts = <0x6 0x8>;
+               interrupt-parent = <0x1>;

This looks wrong.  Shouldn't this be interrupt-parent = <&ipic>?  In
fact, if the root node has interrupt-parent = <&ipic> then the
interrupt-parent property can be omitted from all other nodes unless
they need to override it.

Yes, it should be interrupt-parent = <&ipic>. I will fix it, thanks.

...

quoted

+               // IPIC
+               // interrupts cell = <intr #, sense>
+               // sense values match linux IORESOURCE_IRQ_* defines:
+               // sense == 8: Level, low assertion
+               // sense == 2: Edge, high-to-low change
+               //
+               ipic: interrupt-controller@c00 {
+                       compatible = "fsl,mpc5121-ipic", "fsl,ipic";
+                       interrupt-controller;
+                       #address-cells = <0>;

Don't need #address-cells here

Ok, will remove.

...

quoted

+               mdio@2800 {
+                       compatible = "fsl,mpc5121-fec-mdio";
+                       reg = <0x2800 0x200>;
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       phy: ethernet-phy@0 {
+                               reg = <0x1f>;
+                               device_type = "ethernet-phy";

Remove device_type

Ok.

quoted

+               ethernet@2800 {
+                       device_type = "network";

Ditto

Removing this property results in not functional ethernet,
in particular, the MAC address won't be set by U-Boot. I need
to add aliases node for ethernet0 to fix this. Ok, will remove
this device_type, too.

Thanks,
Anatolij