On Fri, Jan 02, 2009 at 09:41:02AM -0600, Jon Loeliger wrote:

quoted

Link the testcases against the libfdt.so that is built and use
it for the testsuite verification.

Signed-off-by: Josh Boyer <redacted>

Not applied.  Something is wrong here, not quite sure what.

First, after I apply this patch, when I do:

   $ make clean
   $ make check

I get this:

    DEP flattree.c
    DEP dtc.c
    DEP data.c
    DEP checks.c
   CHK version_gen.h
   UPD version_gen.h
    CC tests/get_mem_rsv.o
   cc: -lfdt: linker input file unused because linking not done
    CC libfdt/fdt.o
    CC libfdt/fdt_ro.o
    CC libfdt/fdt_wip.o
    CC libfdt/fdt_sw.o
    CC libfdt/fdt_rw.o
    CC libfdt/fdt_strerror.o
    LD libfdt/libfdt.so
   /usr/bin/ld: cannot find -lfdt
   collect2: ld returned 1 exit status
   make: *** [libfdt/libfdt.so] Error 1

Argh.  Yeah, that's annoying.  I hate makefile dependency crap.

Doing just:

   $ make
   $ make check

seems to clear it up and it finishes building.
So that is promising.

Sort of :)

However, the "make check" yields funny results:

   $ make check

   ********** TEST SUMMARY
   *     Total testcases:1197
   *                PASS:88
   *                FAIL:0
   *   Bad configuration:0
   * Strange test result:1109
   **********

Not sure there at all..

Was that the first version of 'make clean; make check', or
the second version of 'make; make check'?

I ran the tests with 'make; make check' and they all passed
so I'll assume the first.  I think you get odd results
because the testcases aren't actually runnable.  The
cases where it passes are probably expecting error and/or
don't use libfdt (there are a few like that).

Anyway, I have a few things I need to do today and this
weekend so I'll try to fix up this patch as soon as I can.

josh