[PATCH 2/7] firmware_loader: Stop pinning parent device per workqueue invocation
flat view
COLD37d
SUPERSEDED
From: Pratik R. Sampat <hidden>
Date: 2026-09-10 17:02:40
Also in:
lkml
Subsystem:
driver core, kobjects, debugfs and sysfs, firmware loader (request_firmware), the rest · Maintainers:
Greg Kroah-Hartman, "Rafael J. Wysocki", Danilo Krummrich, Johan Hovold, Luis Chamberlain, Linus Torvalds
Status: Superseded by v5 (posted 2026-10-21). [go to v5]
Revision v1 (5 revisions archived).
Revisions (5)
From: Dan Williams <djbw@kernel.org> The device core pins parent devices while children are registered. As long as all usage of the parent device by the firmware_loader ends at firmware_upload_unregister(), no per queue_work() reference is needed. Now that firmware_upload_unregister() holds its own parent device reference over the child device_del() and flush_work() events, the per queue_work() reference can be deleted. Cc: Luis Chamberlain <mcgrof@kernel.org> Cc: Russ Weight <redacted> Cc: Danilo Krummrich <dakr@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "Rafael J. Wysocki" <rafael@kernel.org> Cc: Chao Gao <redacted> Signed-off-by: Dan Williams <djbw@kernel.org> [chao.gao@intel.com: drop unused fw_dev in fw_upload_start()] Signed-off-by: Pratik R. Sampat <redacted> --- drivers/base/firmware_loader/sysfs_upload.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/base/firmware_loader/sysfs_upload.c b/drivers/base/firmware_loader/sysfs_upload.c
index 6f2123538682..890a242a7c20 100644
--- a/drivers/base/firmware_loader/sysfs_upload.c
+++ b/drivers/base/firmware_loader/sysfs_upload.c@@ -176,7 +176,7 @@ static void fw_upload_main(struct work_struct *work) ret = fwlp->ops->prepare(fwl, fwlp->data, fwlp->remaining_size); if (ret != FW_UPLOAD_ERR_NONE) { fw_upload_set_error(fwlp, ret); - goto putdev_exit; + goto out; } fw_upload_update_progress(fwlp, FW_UPLOAD_PROG_TRANSFERRING);
@@ -205,9 +205,7 @@ static void fw_upload_main(struct work_struct *work) if (fwlp->ops->cleanup) fwlp->ops->cleanup(fwl); -putdev_exit: - put_device(fw_dev->parent); - +out: /* * Note: fwlp->remaining_size is left unmodified here to provide * additional information on errors. It will be reinitialized when
@@ -228,7 +226,6 @@ static void fw_upload_main(struct work_struct *work) int fw_upload_start(struct fw_sysfs *fw_sysfs) { struct fw_priv *fw_priv = fw_sysfs->fw_priv; - struct device *fw_dev = &fw_sysfs->dev; struct fw_upload_priv *fwlp; if (!fw_sysfs->fw_upload_priv)
@@ -249,8 +246,6 @@ int fw_upload_start(struct fw_sysfs *fw_sysfs) return -EBUSY; } - get_device(fw_dev->parent); /* released in fw_upload_main */ - fwlp->progress = FW_UPLOAD_PROG_RECEIVING; fwlp->err_code = 0; fwlp->remaining_size = fw_priv->size;
--
2.43.0