[PATCH 2/5] crypto: ti - Fix potential deadlock and allocation bugs in DTHEv2
From: T Pratham <t-pratham@ti.com>
Date: 2026-08-27 10:58:46
Also in:
lkml
Subsystem:
crypto api, the rest, ti data transform and hashing engine (dthe) v2 crypto driver · Maintainers:
Herbert Xu, "David S. Miller", Linus Torvalds, T Pratham
Probe and remove functions use spin_(un)lock for acquiring the
dthe_dev_list.lock. But dthe_get_dev uses the bh variant. Change
spin_(un)lock_bh to spin_(un)lock to avoid potential deadlock when a
softIRQ process tries to acquire the already held lock.
De-register the algorithms before removing the dev_data from linked list
to avoid any allocation during removal.
Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB, CBC)")
Signed-off-by: T Pratham <t-pratham@ti.com>
---
drivers/crypto/ti/dthev2-common.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-common.c
index cc02449382673..b315c850f05d6 100644
--- a/drivers/crypto/ti/dthev2-common.c
+++ b/drivers/crypto/ti/dthev2-common.c@@ -39,11 +39,11 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) if (ctx->dev_data) return ctx->dev_data; - spin_lock_bh(&dthe_dev_list.lock); + spin_lock(&dthe_dev_list.lock); dev_data = list_first_entry_or_null(&dthe_dev_list.dev_list, struct dthe_data, list); if (dev_data) list_move_tail(&dev_data->list, &dthe_dev_list.dev_list); - spin_unlock_bh(&dthe_dev_list.lock); + spin_unlock(&dthe_dev_list.lock); return dev_data; }
@@ -201,12 +201,12 @@ static void dthe_remove(struct platform_device *pdev) { struct dthe_data *dev_data = platform_get_drvdata(pdev); + dthe_unregister_algs(); + spin_lock(&dthe_dev_list.lock); list_del(&dev_data->list); spin_unlock(&dthe_dev_list.lock); - dthe_unregister_algs(); - crypto_engine_exit(dev_data->engine); dma_release_channel(dev_data->dma_aes_rx);
--
2.34.1