Thread (4 messages) 4 messages, 4 authors, 2025-08-30

Re: [PATCH v3] crypto: qat - use kcalloc() in qat_uclo_map_objs_from_mof()

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2025-08-30 08:54:03
Also in: lkml

On Thu, Aug 21, 2025 at 10:20:26PM +0800, Qianfeng Rong wrote:
As noted in the kernel documentation [1], open-coded multiplication in
allocator arguments is discouraged because it can lead to integer overflow.

Use kcalloc() to gain built-in overflow protection, making memory
allocation safer when calculating allocation size compared to explicit
multiplication.  Similarly, use size_add() instead of explicit addition
for 'uobj_chunk_num + sobj_chunk_num'.

Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments #1
Signed-off-by: Qianfeng Rong <redacted>
---
v2: Changed explicit addition 'uobj_chunk_num + sobj_chunk_num' to use
    size_add().
v3: Revise the version description to keep it consistent with the changes.
---
 drivers/crypto/intel/qat/qat_common/qat_uclo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied.  Thanks.
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help