Re: [PATCH] lib/mpi: Add the return value check of kcalloc()

From
Tianjia Zhang <hidden>
Date
2021-12-30 07:26:47
Also in
lkml
Reply to
Zizhuang Deng, 2021-12-30

On 12/30/21 3:03 PM, Zizhuang Deng wrote:
Add the return value check of kcalloc() to avoid potential
NULL ptr dereference.

Signed-off-by: Zizhuang Deng <redacted>
---
Reviewed-by: Tianjia Zhang <redacted>

Best regards,
Tianjia
quoted hunk ↗ jump to hunk
  lib/mpi/mpi-mod.c | 2 ++
  1 file changed, 2 insertions(+)
diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
index 47bc59edd4ff..54fcc01564d9 100644
--- a/lib/mpi/mpi-mod.c
+++ b/lib/mpi/mpi-mod.c
@@ -40,6 +40,8 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
  
  	mpi_normalize(m);
  	ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
+	if (!ctx)
+		return NULL;
  
  	if (copy) {
  		ctx->m = mpi_copy(m);
Thread (3 messages) 3 messages, 3 authors, last reply 2022-01-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help